Skip to content

Added sorting options to ibexa:debug:config - #631

Open
adriendupuis wants to merge 7 commits into
5.0from
enh-ibexa-debug-config
Open

Added sorting options to ibexa:debug:config#631
adriendupuis wants to merge 7 commits into
5.0from
enh-ibexa-debug-config

Conversation

@adriendupuis

@adriendupuis adriendupuis commented Aug 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
🎫 Issue IBX-XXXXX

Description:

Sort parameter list when sortable, when it's an array of arrays by a scalar value's key.

For example, see admin siteaccess field templates by decreasing priority:
php bin/console ibexa:debug:config field_templates --siteaccess admin --sort priority --reverse-sort

For QA:

Documentation:

@adriendupuis
adriendupuis force-pushed the enh-ibexa-debug-config branch 2 times, most recently from ea930f3 to 1aad6d2 Compare August 12, 2025 08:02
@sonarqubecloud

sonarqubecloud Bot commented Aug 12, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

adamwojs
adamwojs reviewed Aug 14, 2025
View reviewed changes
Comment thread src/bundle/Core/Command/DebugConfigResolverCommand.php Outdated
Comment thread src/bundle/Core/Command/DebugConfigResolverCommand.php Outdated
Comment thread src/bundle/Core/Command/DebugConfigResolverCommand.php Outdated
@adriendupuis
adriendupuis marked this pull request as draft August 20, 2025 11:53
@adriendupuis adriendupuis changed the title Added sorting options to ìbexa:debug:config` Added sorting options to ibexa:debug:config Aug 28, 2025
@adriendupuis
adriendupuis force-pushed the enh-ibexa-debug-config branch from b484bd6 to 1050275 Compare October 14, 2025 10:01
@adriendupuis
adriendupuis force-pushed the enh-ibexa-debug-config branch from a3c7fa8 to 7202bcd Compare October 14, 2025 15:07
@adriendupuis
adriendupuis marked this pull request as ready for review October 14, 2025 16:04
@adriendupuis
adriendupuis requested a review from adamwojs October 14, 2025 16:04
adamwojs
adamwojs reviewed Oct 15, 2025
View reviewed changes
Comment thread src/bundle/Core/Command/DebugConfigResolverCommand.php Outdated
if (!array_is_list($parameterData)) {
throw new InvalidArgumentException('--sort', "'$parameter' is a hash but sort can be used only on a list (an array with numeral keys incremented from zero).");
}
for ($i = 0, $count = count($parameterData); $i < $count; ++$i) {

@adamwojs adamwojs Oct 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for ($i = 0, $count = count($parameterData); $i < $count; ++$i) {
foreach ($parameterData as $i => $data) {

@adamwojs
adamwojs requested a review from a team October 15, 2025 06:06
@ezrobot
ezrobot requested review from Steveb-p, adamwojs, alongosz, ciastektk and mikadamczyk and removed request for a team October 15, 2025 06:06
mikadamczyk
mikadamczyk reviewed Oct 15, 2025
View reviewed changes
Comment thread src/bundle/Core/Command/DebugConfigResolverCommand.php
throw new InvalidArgumentException('--sort', "'$sort' property doesn't exist on each '$parameter' list item.");
}
if (!is_scalar($parameterData[$i][$sort])) {
throw new InvalidArgumentException('--sort', "'$sort' properties aren't always scalar and can't be sorted.");

@mikadamczyk mikadamczyk Oct 15, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of letting these input-validation exceptions bubble, you could catch them, print a styled error, and return Command::INVALID or use Command::FAILURE for runtime errors.

Comment thread src/bundle/Core/Command/DebugConfigResolverCommand.php Outdated
if (!array_key_exists($sort, $parameterData[$i])) {
throw new InvalidArgumentException('--sort', "'$sort' property doesn't exist on each '$parameter' list item.");
}
if (!is_scalar($parameterData[$i][$sort])) {

@mikadamczyk mikadamczyk Oct 15, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_scalar() allows bool, int, float, string. Mixed types across items (e.g., "10" and 2, or "abc" and 1) will be coerced by <=>, often in surprising ways (non-numeric strings become 0 in numeric comparisons). You could enforce type consistency across the list for the $sort key, or detect the predominant type and normalize.

Comment thread src/bundle/Core/Command/DebugConfigResolverCommand.php

if (null !== $sort && !empty($parameterData)) {
if (!is_array($parameterData)) {
throw new InvalidArgumentException('--sort', "'$parameter' isn't a list. Sort can be used only on a list.");

@mikadamczyk mikadamczyk Oct 15, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For CLI argument validation you could use a Symfony\Component\Console\Exception\InvalidArgumentException. It integrates better with Console error styling and exit codes.

@sonarqubecloud

sonarqubecloud Bot commented Oct 15, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ibexa-yuna
ibexa-yuna deleted the branch 5.0 April 29, 2026 08:16
@ibexa-yuna ibexa-yuna closed this Apr 29, 2026
@mnocon mnocon reopened this Apr 29, 2026
@sonarqubecloud

sonarqubecloud Bot commented Apr 29, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mnocon
mnocon changed the base branch from main to 5.0 April 29, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikadamczyk mikadamczyk mikadamczyk left review comments
@adamwojs adamwojs Awaiting requested review from adamwojs
@Steveb-p Steveb-p Awaiting requested review from Steveb-p
@alongosz alongosz Awaiting requested review from alongosz
@ciastektk ciastektk Awaiting requested review from ciastektk
@ViniTou ViniTou Awaiting requested review from ViniTou
@barw4 barw4 Awaiting requested review from barw4
@wiewiurdp wiewiurdp Awaiting requested review from wiewiurdp
@konradoboza konradoboza Awaiting requested review from konradoboza
@tbialcz tbialcz Awaiting requested review from tbialcz

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@adriendupuis @adamwojs @mikadamczyk @alongosz @tischsoic @mnocon @ibexa-yuna